fix: remove unintended type conversions when using disjoint_union()#1375
Merged
aviator-app[bot] merged 3 commits intomainfrom Jul 2, 2024
Merged
fix: remove unintended type conversions when using disjoint_union()#1375aviator-app[bot] merged 3 commits intomainfrom
disjoint_union()#1375aviator-app[bot] merged 3 commits intomainfrom
Conversation
Contributor
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
maelle
commented
May 23, 2024
R/operators.R
Outdated
| } | ||
| for (a in seq_along(newattr)) { | ||
| attr[[newattr[a]]] <- c(rep(NA, cumec[i]), ea[[newattr[a]]]) | ||
| if (cumec[i] == 0) { |
Contributor
Author
There was a problem hiding this comment.
noticed because it is 0 in the reprex 😅
Contributor
There was a problem hiding this comment.
I don't understand this. Would it be an opportunity to turn the loop into functional code?
krlmlr
reviewed
May 30, 2024
Contributor
krlmlr
left a comment
krlmlr
left a comment
There was a problem hiding this comment.
Let's wait for the tests in the other PR.
R/operators.R
Outdated
| } | ||
| for (a in seq_along(newattr)) { | ||
| attr[[newattr[a]]] <- c(rep(NA, cumec[i]), ea[[newattr[a]]]) | ||
| if (cumec[i] == 0) { |
Contributor
There was a problem hiding this comment.
I don't understand this. Would it be an opportunity to turn the loop into functional code?
krlmlr
changed the title
disjoint_union()
Contributor
|
We have conflicts? |
krlmlr
force-pushed
the
vctrs
branch
2 times, most recently
from
e47bd2c to
0492dba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #761
Including commits refactoring the test file before I added the test. 😇