Skip to content

docs: Fix error messages mentioning to mention upgrade_graph() instead of the nonexisting upgrade_version()#1252

Merged
aviator-app[bot] merged 1 commit intoigraph:mainfrom
louisaslett:main
Feb 20, 2024
Merged

docs: Fix error messages mentioning to mention upgrade_graph() instead of the nonexisting upgrade_version()#1252
aviator-app[bot] merged 1 commit intoigraph:mainfrom
louisaslett:main

Conversation

@louisaslett
Copy link
Copy Markdown
Contributor

I tried to work with some old saved graphs and encountered the error message:

Error in warn_version(graph) : 
    This graph was created by a now unsupported old igraph version.
    Call upgrade_version() before using igraph functions on that object.

However, there is no upgrade_version() function exported by the igraph package, but there is an upgrade_graph() function which correctly upgrades the old objects. This pull requests just modifies the incorrect error message (and the test results which expect the error output).

@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app bot commented Feb 15, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@krlmlr krlmlr changed the title Fix error messages upgrade_version() -> upgrade_graph() docs: Fix error messages mentioning to mention upgrade_graph() instead of the nonexisting upgrade_version() Feb 20, 2024
@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Feb 20, 2024

Thanks!

@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Feb 20, 2024

Good catch!

@aviator-app aviator-app bot added the blocked label Feb 20, 2024
@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app bot commented Feb 20, 2024

This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. Remove the blocked label to re-queue.

Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts).

@krlmlr krlmlr removed the blocked label Feb 20, 2024
@aviator-app aviator-app bot merged commit 1067918 into igraph:main Feb 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants