Skip to content

CRAN release v2.0.2#1251

Merged
krlmlr merged 4 commits intomainfrom
cran-2.0.2
Feb 14, 2024
Merged

CRAN release v2.0.2#1251
krlmlr merged 4 commits intomainfrom
cran-2.0.2

Conversation

@krlmlr
Copy link
Copy Markdown
Contributor

@krlmlr krlmlr commented Feb 13, 2024

Pre-release checks

  • Review CRP last edited {{{ crp_date }}}.
    {{{ crp_changes }}}
  • Check on win-builder, R devel
  • Review PR
    {{{ check_cran_comments }}}

Action items

  • Run fledge::release(){{{ fledge_gha_workflow_release }}}
  • Confirm CRAN e-mail
  • When the package is accepted on CRAN, run fledge::post_release(){{{ fledge_gha_workflow_release }}}

@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app bot commented Feb 13, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@szhorvat
Copy link
Copy Markdown
Member

szhorvat commented Feb 13, 2024

IMO this should be removed from NEWS because it fixed an issue introduced after 2.0.1.1 was released:

shortest.paths() no longer fails (#1222).


It would be good to put this close to the top and rephrase it so that people who were affected by it will understand it:

configure manage libxml multiple include paths (#1197).

I suggest something like "Fixed invalid quoting of libxml2 include paths".


Great to see this release! This is the "real 2.0", the first truly usable one.

@krlmlr
Copy link
Copy Markdown
Contributor Author

krlmlr commented Feb 13, 2024

Can you please point me to the hash of the C core you used for the last update? The script tools/update-cigraph.sh includes this info in the commit message.

@szhorvat
Copy link
Copy Markdown
Member

szhorvat commented Feb 13, 2024

Good point, I'll leave the commit hash in the commit message next time.

It is fd3b8a6b49c2692a4118efda6050c5efb13e827b

We did deprecate (= rename) a function since then, so do not update the C core to the latest before the R release. There are no relevant fixes to pick up.

The renaming will be easy to adapt to later. In fact now the function name matches between R and C, while previously it didn't.

@krlmlr krlmlr merged commit 020c1d9 into main Feb 14, 2024
@krlmlr krlmlr deleted the cran-2.0.2 branch February 14, 2024 07:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants