test: Add tests for isomorphisms() and subgraph_isomorphisms()#1225
Merged
aviator-app[bot] merged 1 commit intomainfrom Feb 8, 2024
Merged
test: Add tests for isomorphisms() and subgraph_isomorphisms()#1225aviator-app[bot] merged 1 commit intomainfrom
isomorphisms() and subgraph_isomorphisms()#1225aviator-app[bot] merged 1 commit intomainfrom
Conversation
Contributor
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
szhorvat
reviewed
Feb 8, 2024
Comment on lines
+45
to
+53
| test_that("isomorphisms works", { | ||
| motif <- make_empty_graph(directed = FALSE) + | ||
| vertices("D1", "D2", type = c("type1", "type1")) + | ||
| edges("D1", "D2", type = c("type2")) | ||
| subgraph_isomorphisms( | ||
| target = motif, pattern = motif, method = "vf2", | ||
| vertex.color1 = 2:1, vertex.color2 = 1:2 | ||
| ) | ||
| }) |
Member
There was a problem hiding this comment.
The type attribute is unused here. It's not useless to test with target and pattern the same, but normally they should be different, and pattern should be smaller.
For example, let target be a make_ring(10,circular=T) and pattern a make_ring(5, circular=F).
Also, the title should say subgraph isomorphism.
szhorvat
reviewed
Feb 8, 2024
Comment on lines
+67
to
+77
| test_that("subgraph_isomorphisms works", { | ||
| motif <- make_empty_graph(directed = FALSE) + | ||
| vertices("D1", "D2", type = c("type1", "type1")) + | ||
| edges("D1", "D2", type = c("type2")) | ||
| out <- subgraph_isomorphisms( | ||
| target = motif, pattern = motif, method = "vf2", | ||
| vertex.color1 = 2:1, vertex.color2 = 1:2 | ||
| ) | ||
| expect_length(out, 1) | ||
| expect_equal(as.numeric(out[[1]]), 2:1) | ||
| }) |
Member
There was a problem hiding this comment.
This is near-identical to the first one, can the redundancy be reduced?
aviator-app
bot
force-pushed
the
f-iso-tests
branch
from
de169c4 to
374f78d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1219.