fix: Link Fortran runtime on Windows as needed by arpack.#1215
fix: Link Fortran runtime on Windows as needed by arpack.#1215aviator-app[bot] merged 1 commit intoigraph:mainfrom
Conversation
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
krlmlr
left a comment
There was a problem hiding this comment.
Thanks. Do we need the same change in Makevars.win ?
9f5fd70 to
ce46820
Compare
It would be probably cleaner to do so, because Fortran runtime is used. But you probably don't need it, certainly not for aarch64. I am not sure if you need Makevars.win at all, maybe you could delete it and rename the current Makevars.ucrt to Makevars.win. That depends on how old versions of R you want to support (on CRAN). Makevars.ucrt is used by R >= 4.2.0, when it exists. When it doesn't exist, R >= 4.2.0 uses Makevars.win as well as the older versions of R do (details are in Writing R Extensions). At least with R >= 4.2.0 (and so Rtools >= 42), you don't even need to specify "-I" options for LIB_XML, GLPK_HOME, LIB_GMP, the R_TOOLS_SOFT directory is by default made available by the toolchain. So you might need a distinct Makevars.win only if you wanted to support R < 4.2 (with Rtools < 42). |
|
Thanks for your input. I guess I'll go with "never touch a running system" with this respect, and adapt as needed on users's request. |
Fortran libraries (Fortran runtime) is needed e.g. by arpack. This change is to fix building on LLVM/aarch64.