feat: weight support for eccentricity() and radius()

[szhorvat]

Fixes #893

[aviator-app]

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.

---

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

[krlmlr]

Thanks.

• Is the order of functions in functions-R.yaml consistent with that of functions.yaml ? We probably want a simple test for that.
• Can you please add tests for the new functions?

I'm fine with the PR the way it is, we can always refine later.

[maelle]

• I added the lifecycle infrastructure. Does this seem correct @krlmlr?
• I added test cases. Do they make any sense @szhorvat? If so it would make sense to add the same test cases as examples especially for graph_center() that currently has no example.

[krlmlr]

Looks good, thanks!

[szhorvat]

• I added test cases. Do they make any sense @szhorvat? If so it would make sense to add the same test cases as examples especially for graph_center() that currently has no example.

I had a very quick look, seems fine as a smoke test, and yes, the test you added for graph_center() would actually make a very good example (perhaps with a smaller tree).

[maelle]

@szhorvat could you please fix the conflicts in src/cpp11.cpp, or tell me how to fix them? Thank you!

[krlmlr]

cpp11::cpp_register()

[krlmlr]

Needs the decor package.

[szhorvat]

I merged main into this branch and fixed the conflict by regenerating this file using R -q -e 'cpp11::cpp_register()'

Does this mess up Aviator because it won't be able to rebase anymore?

[krlmlr]

Aviator might be fine, I can't identify the reason why it sometimes fails to rebase.

[maelle]

thanks both!

[aviator-app]

This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. Remove the blocked label to re-queue.

Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts).