feat: distances() now supports the Floyd-Warshall algorithm#1186
Merged
aviator-app[bot] merged 3 commits intomainfrom Feb 3, 2024
Merged
feat: distances() now supports the Floyd-Warshall algorithm#1186aviator-app[bot] merged 3 commits intomainfrom
distances() now supports the Floyd-Warshall algorithm#1186aviator-app[bot] merged 3 commits intomainfrom
Conversation
Contributor
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
Contributor
|
Thanks. Moving forward, should we add a test for every new feature? We could also label the new algorithm as "experimental". |
Member
Author
|
I don't think we need to mark this as experimental in R. The reason why it is in C is that the interface might change there (but not the behaviour—it will always return a distance matrix). Do you still want me to do it? Yes, I'll add tests. Unfortunately there were no This is not urgent to merge. |
Contributor
|
Thanks! |
krlmlr
approved these changes
Feb 3, 2024
krlmlr
changed the title
distances() now supports the Floyd-Warshall algorithm
aviator-app
bot
force-pushed
the
feat/floyd-warshall
branch
from
13355e0 to
61e4fbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.