docs: improve docs of assortativity#1151
Conversation
Current Aviator status
This PR was merged using Aviator. See the real-time status of this PR on the Aviator webapp. Use the Aviator Chrome Extension to see the status of your PR within GitHub.
|
|
I'll need to have a more thorough read later, but the documentation should be read carefully and updated as a whole. We need to make sure that the description / formulas for assortativity match the updated included in the C core docs. What happened here (in the C library) was that a more general version of assortativity for implemented, and the docs were significantly expanded. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
I'm sorry, this was a very sloppy review by me, but with this the docs should at least be accurate and complete. We can fix them up when we have the time, after 2.0 ... |
|
It didn't seem sloppy! I've made changes. |
|
@szhorvat could you please re-review this? 🙏 |
szhorvat
left a comment
There was a problem hiding this comment.
I think this should be merged now, as it is all correct. I'll try to make improvements later. Thank you Maëlle!
Co-authored-by: Szabolcs Horvát <szhorvat@gmail.com>
Fix #1132
Based on https://igraph.org/c/doc/igraph-Structural.html#igraph_assortativity
@szhorvat is this correct?