Skip to content

docs: remove scg related docs#1115

Closed
maelle wants to merge 5 commits intomainfrom
scg
Closed

docs: remove scg related docs#1115
maelle wants to merge 5 commits intomainfrom
scg

Conversation

@maelle
Copy link
Copy Markdown
Contributor

@maelle maelle commented Jan 15, 2024

Fix #1109

One of the commits is from #1113

@maelle maelle requested a review from szhorvat January 15, 2024 13:50
@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app bot commented Jan 15, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@maelle
Copy link
Copy Markdown
Contributor Author

maelle commented Jan 15, 2024

 @szhorvat where in the reference would stochastic_matrix() fit? A new subsection?

@maelle maelle marked this pull request as draft January 15, 2024 14:00
@szhorvat
Copy link
Copy Markdown
Member

The stochastic matrix is related to other graph matrices such as the adjacency matrix and the Laplacian matrix. It makes sense to include these three together in the same section.

@maelle
Copy link
Copy Markdown
Contributor Author

maelle commented Jan 16, 2024

"Laplacian matrix" is under "Structural properties" whereas as_adjacency_matrix() is under "Conversion". Should I put stochastic_matrix() under "Structural properties"? Thank you!

@szhorvat
Copy link
Copy Markdown
Member

Let's put a "Matrices" subcategory under Structural Properties and put both the Laplacian and stochastic matrices there. If it is possible to include functions in more than one category, then let's also include as_adjacency_matrix() there (in addition to Conversion).

@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app bot commented Jan 16, 2024

This pull request can't be queued because it's currently a draft.

@maelle
Copy link
Copy Markdown
Contributor Author

maelle commented Jan 16, 2024

I'll rebase after #1113

@aviator-app aviator-app bot closed this in #1167 Feb 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There is still documentation on SCG: remove this; do not associate stochastic_matrix() with SCG

2 participants