Skip to content

refactor: do not duplicate prototypes, use a common header for rinterface.c / rinterface_extra.c#1055

Merged
aviator-app[bot] merged 2 commits intomainfrom
refactor/common-headers
Dec 30, 2023
Merged

refactor: do not duplicate prototypes, use a common header for rinterface.c / rinterface_extra.c#1055
aviator-app[bot] merged 2 commits intomainfrom
refactor/common-headers

Conversation

@szhorvat
Copy link
Copy Markdown
Member

@szhorvat szhorvat commented Dec 30, 2023 •
edited by krlmlr
Loading

Closes #1053

@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app bot commented Dec 30, 2023 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@szhorvat
Copy link
Copy Markdown
Member Author

szhorvat commented Dec 30, 2023

@krlmlr Have a look before I continue.

krlmlr
krlmlr approved these changes Dec 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if it passes checks. Thanks for taking this on.

@aviator-app aviator-app bot removed the mergequeue label Dec 30, 2023
@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app bot commented Dec 30, 2023

This pull request can't be queued because it's currently a draft.

@szhorvat szhorvat marked this pull request as ready for review December 30, 2023 20:10
@szhorvat
Copy link
Copy Markdown
Member Author

szhorvat commented Dec 30, 2023

@krlmlr I added a second commit which:

  • fixes error return types
  • solidified error handling by adding more IGRAPH_CHECK

Good to merge?

There may still be issues with PROTECT, which I don't understand, but I don't think this PR introduced new issues.

@aviator-app aviator-app bot force-pushed the refactor/common-headers branch from 367cc30 to 747db9c Compare December 30, 2023 20:18
@aviator-app aviator-app bot merged commit bfcaad1 into main Dec 30, 2023
@aviator-app aviator-app bot deleted the refactor/common-headers branch December 30, 2023 20:48
@krlmlr krlmlr mentioned this pull request Dec 30, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krlmlr krlmlr krlmlr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Do not duplicate prototypes between rinterface.c and rinterface_extra.c

2 participants

@szhorvat @krlmlr