fix: Fix compilation on Windows with spaces in the Rtools path#1000
Merged
aviator-app[bot] merged 3 commits intomainfrom Dec 14, 2023
Merged
fix: Fix compilation on Windows with spaces in the Rtools path#1000aviator-app[bot] merged 3 commits intomainfrom
aviator-app[bot] merged 3 commits intomainfrom
Conversation
Contributor
Current Aviator status
This PR was merged using Aviator. See the real-time status of this PR on the Aviator webapp. Use the Aviator Chrome Extension to see the status of your PR within GitHub.
|
krlmlr
reviewed
Dec 14, 2023
Contributor
krlmlr
left a comment
krlmlr
left a comment
There was a problem hiding this comment.
Looks good. Should we also tweak Makevars and perhaps other files while we're at it?
krlmlr
changed the title
Contributor
|
Thanks! |
aviator-app
bot
force-pushed
the
ucrt-include
branch
from
0bf3e40 to
56383cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #992.