Skip to content

fix: use beta assemblies for prerelease documentation branches - #349

Merged
ifBars merged 1 commit into
betafrom
fix/docs-beta-release-assemblies
Oct 6, 2026
Merged

ifBars merged 1 commit into
betafrom
fix/docs-beta-release-assemblies

Conversation

@ifBars

@ifBars ifBars commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

Beta prerelease pushes such as releases/3.2.1-beta.8 currently select main game assemblies and fail with missing beta-only types. This recognizes beta and anchored releases/X.Y.Z-beta.N names in the workflow ref and PR source/target refs, while stable releases continue selecting main. Explicit manual dispatch inputs retain precedence, including the existing default main; beta PR labels retain their fallback behavior.

Linked issue

Fixes #348. Confirmed the original failure in run 37166823910/job 111331912636: main assemblies selected, 38 compile errors.

Validation

  • Executed the actual YAML-extracted Bash selector: 40/40 cases passed (18 push, 10 PR, 12 dispatch).
  • Push: literal beta and versioned beta prereleases select beta; stable releases/main/stable/master and malformed or unrelated beta-like names select main.
  • PR: beta source/target and beta prerelease source/target select beta; stable refs select main; beta label selects beta; non-dispatch inputs are ignored.
  • Dispatch: explicit main/beta wins on beta and stable refs; omitted-input fallback uses branch detection. The UI default remains main.
  • Workflow parsed with PyYAML 6.0.3 BaseLoader and duplicate-key rejection; bash -n passed.
  • actionlint 1.7.12 with -shellcheck='' passed (ShellCheck unavailable); git diff --check passed.
  • Local Mono/IL2CPP restore/build/tests could not run: this environment has no .NET SDK or private game assemblies. Hosted validation is recorded below.

Compatibility

Only .github/workflows/docs.yml changes. No public/protected API, runtime behavior, stable IDs, saves, or network payloads change. Cache keys, deployment conditions, and manual-input defaults are preserved.

Contributor checklist

  • Linked an issue opened before this PR with the intended approach.
  • Checked existing issues and PRs for overlapping work.
  • Addresses one focused problem.

Hosted CI results

For commit b39b5dd250040c73df19e3f55fc454b98f822217:

  • Documentation run 37210482825: success. The selector logged beta assemblies and restored the beta assembly cache. S1API Mono build, 775 Mono tests, DocFX, documentation coverage 82.26% (3,400/4,133; minimum 80%), and public API compatibility all passed. Deployment was skipped for this PR.
  • IL2CPP Build Check run 37210482815: success. This workflow builds IL2CPP; it does not run IL2CPP tests.

The original failed release run was not rerun because rerunning would use its old workflow commit. This PR remains unmerged, and the shipped prerelease branch/tag is unchanged. Push and dispatch selection were validated locally against the actual updated step; hosted verification used the PR event.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dee68999-a60b-49d2-b2d4-ba5223ab93db

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ifBars
ifBars merged commit 24386da into beta Oct 6, 2026
4 checks passed
@ifBars
ifBars deleted the fix/docs-beta-release-assemblies branch October 6, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant