Skip to content

fix(Delivery): avoid unused vehicle wrapping when opening Gamepad - #316

Merged
ifBars merged 1 commit into
betafrom
fix/beta-gamepad-settings-hang
Sep 23, 2026
Merged

ifBars merged 1 commit into
betafrom
fix/beta-gamepad-settings-hang

Conversation

@ifBars

@ifBars ifBars commented Sep 23, 2026

Copy link
Copy Markdown
Owner

What changed

The static loading-dock event bridge now checks for subscribers before wrapping vehicles. Opening Gamepad on the 0.4.7f6 IL2CPP beta can assign a static dock occupant; the previous bridge eagerly constructed a LandVehicle wrapper even when no mod listened for the event. In the reproduced case, the second wrapper stalled while reading the native vehicle's Storage property.

Fixes #314.

Reproduction and verification

  • 0.4.7f6 IL2CPP, S1API 3.2.1-beta.3 and beta.4: Settings > Gamepad hung the game in both runs.
  • Same game with the smoke probe alone: Gamepad opened and the process stayed responsive.
  • Removing only S1API's LoadingDock.SetStaticOccupant Harmony patch also allowed Gamepad to open.
  • With this change, the Gamepad panel opened and remained responsive on 0.4.7f6 IL2CPP.
  • MonoMelon suite: 724 passed. Il2CppMelon suite: 710 passed.

The reported game-version field was not needed to reproduce this. The reporter's screenshot shows the same LoadingDock.SetStaticOccupant path.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: d2d7a721-0b66-4c3e-985c-dd69ec8fdc0c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant