Skip to content

slicec Does not Reject Tagged Streamed Parameters #823

Closed

Description

@InsertCreativityHere

Tags are all about adding and removing parameters/fields while maintaining on-the-wire compatibility.
Steamed parameters can always be added/removed without affecting on-the-wire compatibility.

Therefore tagging a streamed parameter never makes sense to do. It's not necessary, and streams use their own encoding, distinct from tags anyways.

slicec should of been rejecting these from the get-go, and the fact it allows tag(6) g: stream int32? at all is an oversight.

What's Changed

slicec now rejects tags on streamed parameters with an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

easyGood for newcomersslice languageRelated to the Slice language itselfslicecRelated to the 'slicec' crate

Type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions