Repository navigation
Removed legacy ThreadLocal annotation on StringDesc's companion object - #755
Merged
Alex009 merged 1 commit intoAug 22, 2024
Merged
Conversation
|
+1 I was debugging this issue today and was minutes away from opening my own issue / PR for this. Thank you @romanandreyvich for beating me to it 😄 |
Alex009
self-requested a review
August 21, 2024 01:53
Author
|
@Alex009 I really apologize for being persistent:) Has this PR any chances to be merged this week? |
Alex009
approved these changes
Aug 22, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation of this PR is the issue: #544
The problem is:
Because StringDesc's companion object marked as ThreadLocal it has different instances for each thread
Since Kotlin 1.8.* released we don't need to use ThreadLocal annotation because of new memory manager.
I've checked that everything works fine without ThreadLocal annotation.
Also all tests works good,
./local-check.shand./local-samples-check.share green :)To test the mentioned issue (#544) is fixed, I've changed a sample a little bit.
Attaching a patch I've used:
patch.diff.zip