Repository navigation
fix(ci): stage desktop app shows its build version, not 0.0.45 - #279
Merged
Merged
Conversation
The bundled web UI reads APP_VERSION from apps/web/package.json at build time, and bk-desktop-release.yml never stamped it, so every BK desktop app showed the committed version. Stamp the package versions before the DMG build, as upstream's release.yml does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
vouch:trusted
Collaborator
Author
|
Merged by bk-agent-01 at head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The stage desktop app shows "Version 0.0.45" in Settings. The app is build
0.0.46-stage-nightly.20261006.2, and the stage server is0.0.46-nightly.20261006.2735.upstream.g78552a8c6162.The bundled web UI reads
APP_VERSIONfromapps/web/package.jsonwhen it is built.bk-desktop-release.ymlpasses the version only to the DMG build (--build-version). It never stamps the package files, so the UI always shows the committed version. This is older than PR #278.What this PR does
It adds one step, "Stamp package versions", before "Build DMG". The step runs
node scripts/update-release-package-versions.ts "<build version>", as upstream'srelease.ymldoes before its desktop builds. The server, desktop, web and contracts packages then carry the build version, so the app shows, for example,0.0.46-stage-nightly.20261007.1.Checks
0.0.46-stage-nightly.20261007.1. It changed only the 4versionfields, and I restored them.stageruns the BK desktop release and proves the label.Not in this PR
bkmainruns the same workflow file from its own branch and has the same gap. This PR changesstageonly.Model: Claude Opus 5.5, Claude Code harness in T3 Code.
🤖 Generated with Claude Code