feat(agent-settings): add enable/disable toggle to detected ACP agents#3322
Open
szafranski wants to merge 1 commit into
Open
feat(agent-settings): add enable/disable toggle to detected ACP agents#3322szafranski wants to merge 1 commit into
szafranski wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
fe4af97 to
a0ca4e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Detected ACP agent cards in Settings → Agent Management were read-only: they
only had a "Go to chat" button, while custom agents already had an enable/disable
Switch. This adds the same on/off toggle to detected ACP agents, so users canturn off vendors they don't want cluttering the agent picker. Toggling off greys the
card, disables its "Go to chat", and removes the agent from the chat picker (the
shared cache is revalidated); toggling on reverses all of it.
The built-in Aion CLI card intentionally keeps no switch and stays always-on.
A disabled Internal/no-command agent fails the backend's
is_disabled_but_installedcheck (
probe_commandreturnsNoCommand), so it would not re-surface in themanagement view and would vanish with no way to re-enable it from the GUI. Omitting
the switch on that one card avoids the trapdoor.
This is a pure renderer change. No backend change is needed:
PATCH /api/agents/:id/enabledalready operates generically on any row byid, and themanagement view already lists disabled-but-installed agents (via
useManagedAgents).Related Issues
Type of Change
Testing
Local checks:
oxfmt,oxlint(0 errors),tsc --noEmit, i18n validation, fullvitestsuite (1402 passed / 3 skipped). NewAgentCarddetected-variant tests coverswitch present/absent and enabled/disabled branches.
Additional Context
The Aion CLI scope decision is deliberate (see Description). No new i18n strings: the
switch has no label and "Go to chat"/"Detected" reuse existing keys.