Repository navigation
Remove systemd from Backplane: agents and work_run run as plain processes, restarts are picked back up - #60
Merged
Merged
Conversation
…processes; a restart or a kill is picked back up by the hub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backplane no longer uses systemd for its own work. Keeping work going across restarts is Backplane's job: when a process dies or the hub restarts, the thread picks back up.
bp-agent-*scopes, the memory-limit setting, the stale-scope cleanup at startup and thesystemctl showdiagnosis are all removed (src/core/contain.benddeleted). An agent killed by SIGKILL now reads "agent was killed (signal 9, likely out of memory)" (Exit.why, lawexit_why_killed). Lost work is told and resumed as before.work_runjobs run as detachedsetsidprocesses, never asbp-<id>units. If a restart cuts one off, it reads as lost, the agent is told and can start it again.work_watchfollows a pid or a file; the systemdunitkind is gone. Stop and check still verify the process identity first.contain_*laws are removed with the code they covered, at the user's request. No other law is touched.Tests:
scripts/check.sh(All terms check),scripts/test.sh89/89, native build. e2e pass: watch, watch_scripts, restart_work, restart, spawn_gen, exit, wake, retire, durable, prep, live, stall.far_e2eandagents_far_e2efail at "they pair by themselves", and fail the same way on a build of unmodified main, so the failure predates this change.