Skip to content

Remove social share links for annotations and groups - #7160

Merged
acelaya merged 1 commit into
mainfrom
remove-share-links
Jun 16, 2025
Merged

Remove social share links for annotations and groups#7160
acelaya merged 1 commit into
mainfrom
remove-share-links

Conversation

@acelaya

@acelaya acelaya commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

Our social share links are outdated (among other things, the Twitter one is still using the old brand icon), and we suspect they are barely used, so this PR removes them from both the annotation and group sharing dialogs.

Before:
image
image

After:
image
image

@codecov

codecov Bot commented Jun 13, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (b3d30d9) to head (92b5223).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7160      +/-   ##
==========================================
- Coverage   99.45%   99.45%   -0.01%     
==========================================
  Files         271      270       -1     
  Lines       10965    10958       -7     
  Branches     2624     2623       -1     
==========================================
- Hits        10905    10898       -7     
  Misses         60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robertknight robertknight left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As a note for the future, we discussed using the Web Share API as a more device/platform-aware alternative to these in future.

@acelaya
acelaya merged commit 8232e60 into main Jun 16, 2025
@acelaya
acelaya deleted the remove-share-links branch June 16, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants