Skip to content

fix(keepopen): honour NO_COLOR and auto-strip ANSI for non-TTY stdout #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 1 commit into from
May 26, 2026
Merged

fix(keepopen): honour NO_COLOR and auto-strip ANSI for non-TTY stdout #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions launcher/keepopen.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,21 @@ GUI_CMD="${3:?keepopen: GUI_CMD required (arg 3) — pass '' if not applicable}"
TUI_CMD="${4:?keepopen: TUI_CMD required (arg 4) — pass '' if not applicable}"
LOG_FILE="${5:-}"

C_RED=$'\033[1;31m'
C_YEL=$'\033[1;33m'
C_CYA=$'\033[1;36m'
C_GRN=$'\033[1;32m'
C_BOLD=$'\033[1m'
C_RST=$'\033[0m'
# Honour NO_COLOR (https://no-color.org/) and auto-detect non-TTY stdout.
# When set, banners and prefix labels emit no ANSI escapes — still loud
# and clearly labelled, just plain text. The freedesktop-style desktop
# launch redirects stdout to a real terminal so this rarely triggers
# automatically, but covers `keepopen.sh ... | tee` and CI captures.
if [[ -n "${NO_COLOR:-}" ]] || [[ ! -t 1 ]]; then
C_RED='' C_YEL='' C_CYA='' C_GRN='' C_BOLD='' C_RST=''
else
C_RED=$'\033[1;31m'
C_YEL=$'\033[1;33m'
C_CYA=$'\033[1;36m'
C_GRN=$'\033[1;32m'
C_BOLD=$'\033[1m'
C_RST=$'\033[0m'
fi

banner() {
# $1 = colour; $2 = title; remaining args = body lines.
Expand Down
Loading