Skip to content

Pre-existing governance/CI failures unrelated to feature PRs (ReScript anti-pattern, Hypatia baseline format, workflow audit) #85

@hyperpolymath

Description

@hyperpolymath

Splitting these out of #84 (test-coverage work) so feature PRs aren't blocked by inherited main failures. All of the below reproduce on main and are independent of any single PR's diff.

1. governance / Language / package anti-pattern policy — failing

Flags committed ReScript (.res) files as a banned language ("use AffineScript instead"):

  • frontier-practices/agents/{Blue,Green,Indigo,Orange,Red,Violet,Yellow}Agent.res, frontier-practices/agents/Types.res
  • frontier-practices/tools/RevealSystem.res

Options: port to AffineScript, or add an exemption via .hypatia-ignore / inline # hypatia:ignore cicd_rules/banned_language_file pragma if these are intentionally ReScript.

2. governance / Validate Hypatia baseline — failing

The validator (jq fallback in the hyperpolymath/standards reusable workflow) requires .hypatia-baseline.json to be an array of finding objects:

type == "array" and all(.[]; has("severity") and has("rule_module") and has("type") and (has("file") or has("file_pattern")))

The committed .hypatia-baseline.json is an object ({ "_comment": ..., "fingerprints": [] }), so type == "array" is false and the step exits 1. The baseline format and the validator's expected schema have diverged — they need reconciling (update the baseline to the array schema, or align the validator/schema in hyperpolymath/standards).

3. Hypatia scan workflow_audit findings (advisory comment on PRs)

  • unpinned_action: governance.yml uses hyperpolymath/standards/.github/workflows/governance-reusable.yml@main (not SHA-pinned). Note the repo's own hooks/validate-sha-pins.sh also flags this.
  • missing_timeout_minutes on several workflows: cflite_batch.yml, cflite_pr.yml, checker-scaling.yml, codeql.yml, governance.yml, hypatia-scan.yml. (The new coverage.yml finding has already been addressed in test: conformance suite, workspace coverage CI, and testing roadmap #84.)

Suggested actions

  • Decide ReScript files: port to AffineScript or exempt via .hypatia-ignore
  • Reconcile .hypatia-baseline.json shape with the validator schema
  • SHA-pin the reusable governance workflow (or document why @main is required)
  • Add timeout-minutes to the listed workflows

https://claude.ai/code/session_014uKLLhZiAGNayhLjdxGXUx

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions