Default rive.view log category to QtInfoMsg - #6
Merged
Conversation
The 2-arg Q_LOGGING_CATEGORY macro defaults the category floor to QtDebugMsg, so qCDebug() diagnostics — notably the per-frame frame-pacing spike detector in RiveView — printed by default and leaked into host-app consoles even at INFO level (Qt categorized logging is independent of the app's own log level). Use the 3-arg form with QtInfoMsg so debug output is opt-in via QT_LOGGING_RULES="rive.view.debug=true", matching the call sites' own comments. qCInfo/qCWarning/qCCritical are unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2-arg Q_LOGGING_CATEGORY macro defaults the category floor to QtDebugMsg, so qCDebug() diagnostics — notably the per-frame frame-pacing spike detector in RiveView — printed by default and leaked into host-app consoles even at INFO level (Qt categorized logging is independent of the app's own log level). Use the 3-arg form with QtInfoMsg so debug output is opt-in via QT_LOGGING_RULES="rive.view.debug=true", matching the call sites' own comments. qCInfo/qCWarning/qCCritical are unaffected.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com