feat: add flag for legacyGet and implement handling in app and core#539
Merged
TillaTheHun0 merged 4 commits intomainfrom Dec 13, 2022
Merged
feat: add flag for legacyGet and implement handling in app and core#539TillaTheHun0 merged 4 commits intomainfrom
legacyGet and implement handling in app and core#539TillaTheHun0 merged 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a flag applied to "get document" on
cacheanddataservices as described in #531 .This should give us the ability to gradually migrate cache and data adapters to return the hyper shape response, and then eventually no longer default to legacy behavior, befor finally removing it.
While I was in the modules, I cleaned up the tests and added some additional coverage. Some more tests are still needed, which i'll cover in a separate issue.
The changes to
hyper-connectwill be pushed in a separate PR.