Convert parametrize argvalues to lists for pytest 10 - #839
Open
faisalsardi-dev wants to merge 1 commit into
Open
Convert parametrize argvalues to lists for pytest 10#839faisalsardi-dev wants to merge 1 commit into
faisalsardi-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What:
Two warnings show up when running
python -Im pytest. They're about a pytest 10 deprecation: iterators passed toparametrizewon't be accepted anymore.How:
Wrap the
itertools.product()calls passed topytest.mark.parametrize()inlist().Why:
product()returns a one-shot iterator. pytest 9 accepts it but emitsPytestRemovedIn10Warning, and pytest 10 will require aCollection.Converting to a list or tuple is the fix documented by pytest:
https://docs.pytest.org/en/stable/deprecations.html#parametrize-iterators
Same 948 tests collected before and after, so the parametrization didn't change.
Most of the diff is re-indentation caused by the added
list()wrapper.git diff -wshows the actual change is two lines per call site.Verification:
Running
python -Im pytestshows the twoPytestRemovedIn10Warnings are gone, reducing the warning count from 2 to 0.I skipped the changelog since this only touches tests.
Pull Request Checklist
mainbranch.api.py.docs/api.rstby hand.versionadded,versionchanged, ordeprecateddirectives..rstand.mdfiles is written using semantic newlines.