Repository navigation
Keep a capturing group's escapes when reversing a conversion pattern - #49772
Merged
Merged
Conversation
IlyasMoutawwakil
force-pushed
the
fg-split/fix-reverse-escaping
branch
from
October 20, 2026 11:08
5c9bef1 to
9837471
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
IlyasMoutawwakil
force-pushed
the
fg-split/fix-reverse-escaping
branch
from
October 20, 2026 11:20
9837471 to
98eb6d8
Compare
IlyasMoutawwakil
force-pushed
the
fg-split/fix-reverse-escaping
branch
from
October 20, 2026 13:33
98eb6d8 to
e6e57ea
Compare
vasqu
reviewed
Oct 20, 2026
Comment on lines
+183
to
+184
| # an unescaped `.` would match any character, so `gateX` would be renamed as well | ||
| self.assertEqual(reverse.rename_source_key("model.mlp.gateX.w")[0], "model.mlp.gateX.w") |
Collaborator
There was a problem hiding this comment.
wait why would we want this? based gate\. shouldnt this only match gate. as it's an escaped dot not a general regex dot?
Member
Author
There was a problem hiding this comment.
the commetn described the behaviour on main, it's checking exactly what you described, model.mlp.gateX.w stays as is
Member
Author
There was a problem hiding this comment.
updated the comment
IlyasMoutawwakil
force-pushed
the
fg-split/fix-reverse-escaping
branch
from
October 20, 2026 16:04
e6e57ea to
d8ab562
Compare
IlyasMoutawwakil
force-pushed
the
fg-split/fix-reverse-escaping
branch
2 times, most recently
from
October 21, 2026 07:24
f44141e to
ae330b5
Compare
IlyasMoutawwakil
marked this pull request as ready for review
October 21, 2026 07:30
IlyasMoutawwakil
force-pushed
the
fg-split/fix-reverse-escaping
branch
from
October 21, 2026 07:52
ae330b5 to
db967b4
Compare
IlyasMoutawwakil
force-pushed
the
fg-split/fix-reverse-escaping
branch
from
October 23, 2026 13:03
db967b4 to
ec304d1
Compare
process_target_pattern unescaped \. before extracting the capturing group, so the reversed rename's group matched any character in place of a dot. Unescape only outside the group. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
IlyasMoutawwakil
force-pushed
the
fg-split/fix-reverse-escaping
branch
from
October 23, 2026 13:35
ec304d1 to
d3f29df
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cyrilvallez
approved these changes
Oct 27, 2026
Cyrilvallez
left a comment
Cyrilvallez
left a comment
Member
There was a problem hiding this comment.
LGTM thanks! In general aligned with this change as it makes it more robust, though for minimax m3 a simple change in the patterns will look a bit better instead, see my comment/commit there!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What.
process_target_patternunescaped\.before it took out the capturing group. The reversed group thenmatched any character where the pattern meant a dot. The unescape now runs after the group is taken out.
Why we need it. Saving MiniMax-M3 MXFP8 checkpoints in #49780 blocked on it. Its MoE rename (#49786) is the first
reversible mapping with an escaped dot in a capturing group. Reversed without this fix, the group matched any
character in place of the dot, and the save wrote wrong keys. No mapping on main has such a group yet.
Depends on. #49771 (stacked for a linear stack; no code dependency).
How tested.
tests/utils/test_core_model_loading.py::test_reverse_keeps_escaped_dots_in_capturing_group. The-k test_reverse_loading_mappingmodel tests give the same results as main.The comments and docstrings that say why each change exists are there for readability. Feel free to ask for any of them to go if it's self-evident.
🤖 Generated with Claude Code