Repository navigation
Conversation
Contributor
CI recapDashboard: View test results in Grafana |
Member
|
Existing PR at #45649 so I'm going to try to wake that one up instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #49297 by preventing FSDP2 non-rank-0 processes from materializing the entire model onto the host CPU during
from_pretrained.Root Cause
FSDP1 and FSDP2 both export identical distributed environment variables (
ACCELERATE_USE_FSDP=1). When loading missing keys frommetadevices in_move_missing_keys_from_meta_to_device(),transformersassumes this implies FSDP1 and iterates over all parameters to allocatetorch.zeros_like(param, device="cpu"). For FSDP2—which natively broadcasts meta-tensors from rank-0—this is entirely redundant and causes immediate Host OOMs for large models.Changes
src/transformers/modeling_utils.pyusingaccelerate.state.is_initialized().meta.PartialStateto ensure FSDP2 paths leave weights on the meta device.is_fsdp_enabled()helper remains strictly generic to avoid breaking upstreamacceleratedispatch paths.