Skip to content

Migrate torchao integration off deleted torchao.dtypes - #47797

Merged
SunMarc merged 1 commit into
huggingface:mainfrom
vkuzo:20260805_torchao_dtypes_depr
Aug 5, 2026
Merged

SunMarc merged 1 commit into
huggingface:mainfrom
vkuzo:20260805_torchao_dtypes_depr

Conversation

@vkuzo

@vkuzo vkuzo commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

CI

torchao removed the torchao/dtypes package (AffineQuantizedTensor and the Layout classes). This updates the transformers torchao integration to stop importing from torchao.dtypes so it no longer crashes against current torchao, mirroring the approach in transformers #45321.

Changes:

  • integrations/torchao.py: drop the _quantization_type helper and its from torchao.dtypes import AffineQuantizedTensor isinstance branch; _linear_extra_repr now detects quantized weights inline via isinstance(self.weight, TorchAOBaseTensor) (from torchao.utils).
  • tests/quantization/torchao_integration/test_torchao.py: replace the from torchao.dtypes import AffineQuantizedTensor import with from torchao.utils import TorchAOBaseTensor and update the isinstance assertions accordingly.
  • docs/source/en/quantization/torchao.md: remove the MarlinSparseLayout ("int4-weight-only-24sparse") examples and migrate the Int4CPULayout example to Int4WeightOnlyConfig(int4_packing_format=PLAIN_INT32).

Test plan:

  • python -c "import transformers.integrations.torchao" imports cleanly.

  • RUN_SLOW=1 pytest tests/quantization/torchao_integration/test_torchao.py: all 18 TorchAOBaseTensor isinstance / FqnToConfig tests pass. The 3 remaining failures (test_int4wo_quant, test_int4wo_offload, test_serialization_accelerator_*_Int4WeightOnlyConfig) are pre-existing generation-output text comparisons pinned to torchao int4 kernel numerics on the test hardware, unrelated to this change.

  • (First-time contributors only): I confirm that this PR description and code is not written by an LLM or code agent

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline and the
    Pull Request checks?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes according to the guidelines?
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

torchao removed the torchao/dtypes package (AffineQuantizedTensor and the
Layout classes). This updates the transformers torchao integration to stop
importing from torchao.dtypes so it no longer crashes against current
torchao, mirroring the approach in transformers huggingface#45321.

Changes:
- integrations/torchao.py: drop the `_quantization_type` helper and its
  `from torchao.dtypes import AffineQuantizedTensor` isinstance branch;
  `_linear_extra_repr` now detects quantized weights inline via
  `isinstance(self.weight, TorchAOBaseTensor)` (from torchao.utils).
- tests/quantization/torchao_integration/test_torchao.py: replace the
  `from torchao.dtypes import AffineQuantizedTensor` import with
  `from torchao.utils import TorchAOBaseTensor` and update the isinstance
  assertions accordingly.
- docs/source/en/quantization/torchao.md: remove the MarlinSparseLayout
  ("int4-weight-only-24sparse") examples and migrate the Int4CPULayout
  example to `Int4WeightOnlyConfig(int4_packing_format=PLAIN_INT32)`.

Test plan:
- `python -c "import transformers.integrations.torchao"` imports cleanly.
- `RUN_SLOW=1 pytest tests/quantization/torchao_integration/test_torchao.py`:
  all 18 TorchAOBaseTensor isinstance / FqnToConfig tests pass. The 3
  remaining failures (test_int4wo_quant, test_int4wo_offload,
  test_serialization_accelerator_*_Int4WeightOnlyConfig) are pre-existing
  generation-output text comparisons pinned to torchao int4 kernel numerics
  on the test hardware, unrelated to this change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: torchao_integration

@vkuzo

vkuzo commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

cc @SunMarc , do you know who could help review/merge this?

context - making sure transformers follows the torchao deletion in pytorch/ao#4696

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

CI recap

Dashboard: View test results in Grafana
Latest run: 30998997362:2
Result: success | Jobs: 16 | Tests: 173,174 | Failures: 0 | Duration: 13h 29m

@SunMarc SunMarc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this update ! I indeed saw a lot of breaking tests due to the latest version of torchao.

from transformers import TorchAoConfig, AutoModelForCausalLM, AutoTokenizer
from torchao.quantization import Int4WeightOnlyConfig
from torchao.dtypes import Int4CPULayout
from torchao.quantization.quantize_.workflows import Int4PackingFormat

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this safe to import even with prior version of torchao ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that should work for torchao version 0.15+, which is what is supported by hf

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@SunMarc
SunMarc added this pull request to the merge queue Aug 5, 2026
Merged via the queue into huggingface:main with commit 0c98a99 Aug 5, 2026
115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants