Repository navigation
Refactor SpeechT5 output tracing to standardized output capture - #44129
Closed
preetam1407 wants to merge 1 commit into
Closed
preetam1407 wants to merge 1 commit into
preetam1407 wants to merge 1 commit into
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: speecht5 |
This was referenced Apr 21, 2026
This was referenced Apr 29, 2026
Collaborator
|
Thanks for the SpeechT5 refactor, @preetam1407! The #43979 call to contributions was closed right after this was opened and we couldn't review all the PRs it produced, so I'm closing this one. Sorry it didn't get looked at in time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors SpeechT5 to the standardized output tracing interface.
@capture_outputsto base encoder/decoder forwards._can_record_outputsmappings for hidden states and attentions.@can_return_tupleto wrapper/task forwards.output_attentions/output_hidden_states/return_dictplumbing.Fixes #43979
Who can review?
@eustlb @ebezzam @vasqu @molbap