-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Added knip #1701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added knip #1701
Changes from all commits
2dd2aed
a82161f
2af13f1
62a6717
7253096
8fece72
8d8856a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,17 +57,18 @@ | |
| "dependencies": { | ||
| "@huggingface/jinja": "^0.5.6", | ||
| "@huggingface/tokenizers": "^0.1.3", | ||
| "onnxruntime-common": "1.24.3", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I remember someone mentioned this before, but since onnxruntime-node and onnxruntime-web depend on it, I don't think it's necessary to define here. but I suppose if there is a mismatch one day between e.g., Lmk what you think!
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should keep this as a direct dependency because The version mismatch concern is valid, but declaring it directly makes the resolved version explicit instead of depending on hoisting. If ORT node/web diverge further, we should probably revisit the ORT versions together rather than rely on a transitive copy. |
||
| "onnxruntime-node": "1.24.3", | ||
| "onnxruntime-web": "1.26.0-dev.20260416-b7804b056c", | ||
| "sharp": "^0.34.5" | ||
| }, | ||
| "devDependencies": { | ||
| "@jest/globals": "30.2.0", | ||
| "@types/jest": "^30.0.0", | ||
| "@types/node": "^24.1.0", | ||
| "@webgpu/types": "^0.1.69", | ||
| "esbuild": "^0.27.2", | ||
| "jest": "^30.2.0", | ||
| "jest-environment-node": "^30.2.0", | ||
| "jsdoc-to-markdown": "^9.1.3", | ||
|
Comment on lines
+66
to
72
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you explain the jest-environment-node -> jest/globals package change?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was one of the suggestions from knip since we don't use it.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh and about the "@jest/globals": knip found that we import @jest/globals in two places in the project but we don't have it in the dependencies. It never caused an issue because I think its still somewhere in the dependency tree, but as I said in the "onnxruntime-common", whenever we import a package directly, we should also have it in our dependencies. |
||
| "typescript": "5.9.3" | ||
| }, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,6 @@ | ||
| export const GITHUB_ISSUE_URL = 'https://github.com/huggingface/transformers.js/issues/new/choose'; | ||
|
|
||
| export const CONFIG_NAME = 'config.json'; | ||
| export const FEATURE_EXTRACTOR_NAME = 'preprocessor_config.json'; | ||
| export const IMAGE_PROCESSOR_NAME = FEATURE_EXTRACTOR_NAME; | ||
| export const IMAGE_PROCESSOR_NAME = 'preprocessor_config.json'; | ||
| export const PROCESSOR_NAME = 'processor_config.json'; | ||
| export const CHAT_TEMPLATE_NAME = 'chat_template.jinja'; | ||
| export const GENERATION_CONFIG_NAME = 'generation_config.json'; |
|
nico-martin marked this conversation as resolved.
|
Uh oh!
There was an error while loading. Please reload this page.