Skip to content

FIX Update signature for resolve_lora_variant - #2618

Merged
BenjaminBossan merged 2 commits into
huggingface:mainfrom
BenjaminBossan:fix-resolve-lora-variant-signature-qalora
Jun 27, 2025
Merged

BenjaminBossan merged 2 commits into
huggingface:mainfrom
BenjaminBossan:fix-resolve-lora-variant-signature-qalora

Conversation

@BenjaminBossan

@BenjaminBossan BenjaminBossan commented Jun 27, 2025 •

Copy link
Copy Markdown
Member

The function signature was missing **kwargs, which results in a failure after merging #2571.

The function signature was missing **kwargs, which results in a failure
after merging huggingface#2571.
@BenjaminBossan

BenjaminBossan commented Jun 27, 2025 •

Copy link
Copy Markdown
Member Author

Note: CI cancelled for now as we're waiting for another PR to be merged, which makes tests pass again with transformers 4.53.0

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@BenjaminBossan
BenjaminBossan merged commit 4562926 into huggingface:main Jun 27, 2025
@BenjaminBossan
BenjaminBossan deleted the fix-resolve-lora-variant-signature-qalora branch June 27, 2025 14:57
efraimdahl pushed a commit to efraimdahl/peft that referenced this pull request Jul 12, 2025
The function signature was missing **kwargs, which results in a failure
after merging huggingface#2571.
iambogeumkim pushed a commit to iambogeumkim/peft that referenced this pull request Jun 21, 2026
The function signature was missing **kwargs, which results in a failure
after merging huggingface#2571.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants