make `pipelines` tests device-agnostic (part1) by faaany · Pull Request #9399 · huggingface/diffusers

faaany · 2024-09-09T22:02:31Z

What does this PR do?

Below are some evidences:

PASSED tests/pipelines/animatediff/test_animatediff.py::AnimateDiffPipelineFastTests::test_to_device
PASSED tests/pipelines/amused/test_amused.py::AmusedPipelineFastTests::test_model_cpu_offload_forward_pass
PASSED tests/pipelines/amused/test_amused.py::AmusedPipelineFastTests::test_cpu_offload_
forward_pass_twice
PASSED tests/pipelines/amused/test_amused_inpaint.py::AmusedInpaintPipelineFastTests::te
st_to_device

@yiyixuxu

sayakpaul · 2024-09-10T01:34:33Z

Could you provide some details about the machine you used to run the tests changed in this PR?

faaany · 2024-09-10T01:36:32Z

Could you provide some details about the machine you used to run the tests changed in this PR?

yes, I am running on Intel(R) Data Center GPU Max 1550.

faaany · 2024-09-10T01:45:15Z

Could you provide some details about the machine you used to run the tests changed in this PR?

xpu is the common device name for intel gpu.

faaany · 2024-09-12T07:54:10Z

Hi @sayakpaul , any concern on this PR?

faaany · 2024-09-13T04:49:37Z

could you pls help retrigger the CI? Thx a lot!

Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>

faaany · 2024-11-11T03:21:11Z

Thanks for the comments. Code Update!

IlyasMoutawwakil · 2024-11-18T09:40:01Z

@faaany can you please run styling on this branch and apply the same comments to part 2 PR ? (require_non_cpu is still defined and used there)

faaany · 2024-11-18T10:15:53Z

@faaany can you please run styling on this branch and apply the same comments to part 2 PR ? (require_non_cpu is still defined and used there)

Thanks for the review! Style fixed and let me un-draft the part2 PR, once this one got merged

IlyasMoutawwakil · 2024-11-18T10:49:10Z

@faaany your changes didn't pass the code quality check, can you do make style && make quality

faaany · 2024-11-18T10:54:05Z

@faaany your changes didn't pass the code quality check, can you do make style && make quality

done

a-r-r-o-w

Thanks for the awesome work here! I think this looks good to merge and the failing tests are unrelated (I've restarted them anyway to make it go away). Off to @DN6 for merging since he has much more experience on the tests front

faaany · 2024-11-21T07:21:30Z

Hi @DN6 , could you take a look at this PR?

* enable on xpu * add 1 more * add one more * enable more * add 1 more * add more * enable 1 * enable more cases * enable * enable * update comment * one more * enable 1 * add more cases * enable xpu * add one more caswe * add more cases * add 1 * add more * add more cases * add case * enable * add more * add more * add more * enbale more * add more * update code * update test marker * add skip back * update comment * remove single files * remove * style * add * revert * reformat * update decorator * update * update * update * Update tests/pipelines/deepfloyd_if/test_if.py Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com> * Update src/diffusers/utils/testing_utils.py Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com> * Update tests/pipelines/animatediff/test_animatediff_controlnet.py Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com> * Update tests/pipelines/animatediff/test_animatediff.py Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com> * Update tests/pipelines/animatediff/test_animatediff_controlnet.py Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com> * update float16 * no unitest.skipt * update * apply style check * reapply format --------- Co-authored-by: Sayak Paul <spsayakpaul@gmail.com> Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>

faaany added 6 commits September 9, 2024 14:47

enable on xpu

275b6af

add 1 more

f422d55

add one more

84540d9

enable more

b94f751

add 1 more

fa508a4

add more

a04fedf

faaany marked this pull request as ready for review September 9, 2024 22:55

faaany added 8 commits September 9, 2024 16:20

enable 1

7442dc1

enable more cases

658789a

enable

06c77c7

enable

1bf9b0c

update comment

6296e88

one more

6d0b378

enable 1

0d9f975

add more cases

732ff3a

faaany added 2 commits September 9, 2024 22:15

enable xpu

3803d93

Merge branch 'main' into enable_xpu

1825fd5

Merge branch 'main' into enable_xpu

0666a53

faaany added 2 commits September 12, 2024 22:38

add one more caswe

e00bcca

add more cases

6513201

sayakpaul requested a review from yiyixuxu September 13, 2024 05:46

faaany added 4 commits September 12, 2024 23:01

add 1

3cb0f96

add more

314e76d

add more cases

65c95e9

add case

2882ee4

yiyixuxu reviewed Nov 8, 2024

View reviewed changes

Comment thread tests/pipelines/deepfloyd_if/test_if.py Outdated

DN6 reviewed Nov 8, 2024

View reviewed changes

faaany and others added 9 commits November 11, 2024 09:23

Merge branch 'huggingface:main' into enable_xpu

f73a38a

Update tests/pipelines/deepfloyd_if/test_if.py

7ef5dab

Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>

Update src/diffusers/utils/testing_utils.py

915c741

Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>

Update tests/pipelines/animatediff/test_animatediff_controlnet.py

e0507b5

Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>

Update tests/pipelines/animatediff/test_animatediff.py

97f0e9e

Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>

Update tests/pipelines/animatediff/test_animatediff_controlnet.py

451790f

Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>

update float16

b671e25

no unitest.skipt

35de6d3

update

64ef84a

Merge branch 'main' into enable_xpu

9c4db33

sayakpaul and others added 2 commits November 18, 2024 15:13

Merge branch 'main' into enable_xpu

227ea9f

apply style check

c045524

reapply format

05ce461

a-r-r-o-w approved these changes Nov 18, 2024

View reviewed changes

a-r-r-o-w requested a review from DN6 November 18, 2024 20:41

Merge branch 'main' into enable_xpu

201e2db

DN6 approved these changes Nov 22, 2024

View reviewed changes

DN6 merged commit 64b3e0f into huggingface:main Nov 22, 2024

faaany mentioned this pull request Jan 3, 2025

[tests] make tests device-agnostic (part 3) #10437

Merged

yao-matrix mentioned this pull request Apr 29, 2025

enable unidiffuser test cases on xpu #11444

Merged

Uh oh!

Conversation

faaany commented Sep 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Uh oh!

sayakpaul commented Sep 10, 2024

Uh oh!

faaany commented Sep 10, 2024

Uh oh!

faaany commented Sep 10, 2024

Uh oh!

faaany commented Sep 12, 2024

Uh oh!

faaany commented Sep 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

faaany commented Nov 11, 2024

Uh oh!

IlyasMoutawwakil commented Nov 18, 2024

Uh oh!

faaany commented Nov 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IlyasMoutawwakil commented Nov 18, 2024

Uh oh!

faaany commented Nov 18, 2024

Uh oh!

a-r-r-o-w left a comment

Choose a reason for hiding this comment

Uh oh!

faaany commented Nov 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

faaany commented Sep 9, 2024 •

edited

Loading

faaany commented Nov 18, 2024 •

edited

Loading