Skip to content

Fix num images per prompt unclip#1787

Merged
patil-suraj merged 6 commits into
mainfrom
fix-num_images_per_prompt-unclip
Dec 20, 2022
Merged

Fix num images per prompt unclip#1787
patil-suraj merged 6 commits into
mainfrom
fix-num_images_per_prompt-unclip

Conversation

@patil-suraj

@patil-suraj patil-suraj commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

Use repeat_interleave instead of repeat to duplicate the attention masks.
fixes #1785

This PR also adpats the test envs to use released accelerate version rather than main, as test_from_save_pretrained_dtype tests are faling with accelerate main as a result of huggingface/accelerate#920

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Dec 20, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@patil-suraj patil-suraj requested a review from pcuenca December 20, 2022 14:14

@anton-l anton-l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! One more line to remove is ${CONDA_RUN} python -m pip install git+https://github.com/huggingface/accelerate in the standalone MPS tests

@pcuenca pcuenca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@patil-suraj patil-suraj merged commit d07f730 into main Dec 20, 2022
@patil-suraj patil-suraj deleted the fix-num_images_per_prompt-unclip branch December 20, 2022 15:03
anton-l pushed a commit that referenced this pull request Dec 20, 2022
* use repeat_interleave

* fix repeat

* Trigger Build

* don't install accelerate from main

* install released accelrate for mps test

* Remove additional accelerate installation from main.

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
sliard pushed a commit to sliard/diffusers that referenced this pull request Dec 21, 2022
* use repeat_interleave

* fix repeat

* Trigger Build

* don't install accelerate from main

* install released accelrate for mps test

* Remove additional accelerate installation from main.

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* use repeat_interleave

* fix repeat

* Trigger Build

* don't install accelerate from main

* install released accelrate for mps test

* Remove additional accelerate installation from main.

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

num_images_per_prompt > 1 still broken with UnCLIPPipeline

4 participants