[CI] Refactor Skyreels, Lumina, Ominigen, Mochi transformer tests#13348
Merged
Conversation
sayakpaul
reviewed
Mar 30, 2026
| from ..testing_utils import ( | ||
| BaseModelTesterConfig, | ||
| ModelTesterMixin, | ||
| TorchCompileTesterMixin, |
Member
There was a problem hiding this comment.
Maybe compilation tests are not needed?
| from ..testing_utils import ( | ||
| BaseModelTesterConfig, | ||
| ModelTesterMixin, | ||
| TorchCompileTesterMixin, |
| from ..testing_utils import ( | ||
| BaseModelTesterConfig, | ||
| ModelTesterMixin, | ||
| TorchCompileTesterMixin, |
| from ..testing_utils import ( | ||
| BaseModelTesterConfig, | ||
| ModelTesterMixin, | ||
| TorchCompileTesterMixin, |
| from ..testing_utils import ( | ||
| BaseModelTesterConfig, | ||
| ModelTesterMixin, | ||
| TorchCompileTesterMixin, |
This was referenced May 29, 2026
sayakpaul
approved these changes
Jun 4, 2026
Member
|
Should we keep the LoRA tests where relevant? I feel like that should be ensured? |
Collaborator
Author
@sayakpaul |
Member
|
If usage is considered, then okay makes sense to not do LoRA. |
DN6
added a commit
that referenced
this pull request
Jul 1, 2026
…3348) * update * update --------- Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.