Skip to content

[train_dreambooth_lora.py] Set LANCZOS as default interpolation mode for resizing#11421

Merged
asomoza merged 2 commits into
huggingface:mainfrom
merterbak:main
Apr 26, 2025
Merged

[train_dreambooth_lora.py] Set LANCZOS as default interpolation mode for resizing#11421
asomoza merged 2 commits into
huggingface:mainfrom
merterbak:main

Conversation

@merterbak

Copy link
Copy Markdown
Contributor

What does this PR do?

It makes LANCZOS the default interpolation mode for the image resizing. It fixes #11390.

Before submitting

Who can review?

@asomoza

@merterbak merterbak changed the title Set LANCZOS as default interpolation mode for resizing [train_dreambooth_lora.py] [train_dreambooth_lora.py] Set LANCZOS as default interpolation mode for resizing Apr 25, 2025
@merterbak merterbak changed the title [train_dreambooth_lora.py] Set LANCZOS as default interpolation mode for resizing [train_dreambooth_lora.py] Set LANCZOS as default interpolation mode for resizing Apr 25, 2025
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@asomoza

asomoza commented Apr 26, 2025

Copy link
Copy Markdown
Member

thanks @merterbak, for contributing in diffusers you have to format the code, can you run these two commands on the console:

make style
make quality

If for some reason you can't run them, I can run a bot that does this for you, but it's always better to run it yourself, specially for larger contributions of code with multiple reviews.

@merterbak

Copy link
Copy Markdown
Contributor Author

Ok, thank you for valuable advice.

@asomoza asomoza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@asomoza

asomoza commented Apr 26, 2025

Copy link
Copy Markdown
Member

failing test are not related to this PR

@asomoza asomoza merged commit bd96a08 into huggingface:main Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better image interpolation in training scripts follow up

3 participants