Skip to content

deepspeed version 0.6.7 fix#544

Merged
pacman100 merged 5 commits into
huggingface:mainfrom
pacman100:smangrul/deepspeed-test-hotfix
Jul 22, 2022
Merged

deepspeed version 0.6.7 fix#544
pacman100 merged 5 commits into
huggingface:mainfrom
pacman100:smangrul/deepspeed-test-hotfix

Conversation

@pacman100

@pacman100 pacman100 commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

  1. DeepSpeed integration is broken when using the latest deepspeed 0.6.7 version. This PR fixes it.

Tracking in accelerate with issue #536

@pacman100 pacman100 requested review from muellerzr and sgugger July 21, 2022 12:31

@muellerzr muellerzr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Might be worth keeping an issue open about this until its resolved to send people to as they get issues/they can find it easily

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Jul 21, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread setup.py Outdated

@sgugger sgugger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to actually fix the root of the issue!

Comment thread src/accelerate/state.py

@muellerzr muellerzr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@pacman100 pacman100 changed the title deepspeed version hotfix deepspeed version 0.6.7 fix Jul 22, 2022
@pacman100 pacman100 merged commit e98dc22 into huggingface:main Jul 22, 2022
@pacman100 pacman100 deleted the smangrul/deepspeed-test-hotfix branch July 27, 2022 04:20
@pacman100 pacman100 mentioned this pull request Mar 2, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants