Skip to content

fix(opencode_env): remove non-existent tests package from setuptools config#741

Merged
burtenshaw merged 3 commits into
mainfrom
fix/opencode-env-missing-tests-dir
Jun 4, 2026
Merged

fix(opencode_env): remove non-existent tests package from setuptools config#741
burtenshaw merged 3 commits into
mainfrom
fix/opencode-env-missing-tests-dir

Conversation

@sergiopaniego

Copy link
Copy Markdown
Member

Summary

Removes opencode_env.tests from the [tool.setuptools] packages list in
envs/opencode_env/pyproject.toml. The directory envs/opencode_env/tests/
was declared but never created, causing uv sync --no-editable to fail during
Docker builds with:

error: package directory 'tests' does not exist

Introduced in PR #656. Not caught earlier because pip install -e . (editable
mode) doesn't validate package directories at install time — only --no-editable
does, which is what the Dockerfile uses.

It generates an error in GH Action (see https://github.com/huggingface/OpenEnv/actions/runs/26807926904/job/79030213083)

@adithya-s-k @burtenshaw

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • New environment
  • Refactoring

Alignment Checklist

Before submitting, verify:

  • I have read .claude/docs/PRINCIPLES.md and this PR aligns with our principles
  • I have checked .claude/docs/INVARIANTS.md and no invariants are violated
  • I have run /pre-submit-pr (or bash .claude/hooks/lint.sh and tests) and addressed all issues

RFC Status

  • Not required (bug fix, docs, minor refactoring)
  • RFC exists: #___
  • RFC needed (will create before merge)

Test Plan

The Docker build for envs/opencode_env should complete without error. Verify
by running the build-envs CI workflow or locally:

docker build -f envs/opencode_env/server/Dockerfile envs/opencode_env

Claude Code Review

N/A

@Darktex Darktex left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This is an automated review by Claude Code, not a human review.


Alignment Review Report

Automated Checks

  • Lint: PASS (only pyproject.toml changed)
  • Debug code: CLEAN

Tier 1: Fixes Required

None. The fix is correct — envs/opencode_env/tests/ does not exist, and removing the opencode_env.tests package reference from both packages and package-dir eliminates the uv sync --no-editable failure.

Tier 2: Alignment Discussion

None. Narrow build config fix with no impact on APIs, invariants, or principles.

Summary

  • 0 mechanical issues
  • 0 alignment points
  • Safe to merge.

Automated review by Claude Code

@bot-ci-comment

bot-ci-comment Bot commented Jun 3, 2026

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@burtenshaw burtenshaw merged commit 9dc6195 into main Jun 4, 2026
7 checks passed
@sergiopaniego sergiopaniego deleted the fix/opencode-env-missing-tests-dir branch June 4, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants