fix(opencode_env): remove non-existent tests package from setuptools config#741
Merged
Conversation
Darktex
approved these changes
Jun 3, 2026
Darktex
left a comment
Collaborator
There was a problem hiding this comment.
Note: This is an automated review by Claude Code, not a human review.
Alignment Review Report
Automated Checks
- Lint: PASS (only
pyproject.tomlchanged) - Debug code: CLEAN
Tier 1: Fixes Required
None. The fix is correct — envs/opencode_env/tests/ does not exist, and removing the opencode_env.tests package reference from both packages and package-dir eliminates the uv sync --no-editable failure.
Tier 2: Alignment Discussion
None. Narrow build config fix with no impact on APIs, invariants, or principles.
Summary
- 0 mechanical issues
- 0 alignment points
- Safe to merge.
Automated review by Claude Code
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
burtenshaw
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
opencode_env.testsfrom the[tool.setuptools]packages list inenvs/opencode_env/pyproject.toml. The directoryenvs/opencode_env/tests/was declared but never created, causing
uv sync --no-editableto fail duringDocker builds with:
error: package directory 'tests' does not exist
Introduced in PR #656. Not caught earlier because
pip install -e .(editablemode) doesn't validate package directories at install time — only
--no-editabledoes, which is what the Dockerfile uses.
It generates an error in GH Action (see https://github.com/huggingface/OpenEnv/actions/runs/26807926904/job/79030213083)
@adithya-s-k @burtenshaw
Type of Change
Alignment Checklist
Before submitting, verify:
.claude/docs/PRINCIPLES.mdand this PR aligns with our principles.claude/docs/INVARIANTS.mdand no invariants are violated/pre-submit-pr(orbash .claude/hooks/lint.shand tests) and addressed all issuesRFC Status
Test Plan
The Docker build for
envs/opencode_envshould complete without error. Verifyby running the
build-envsCI workflow or locally:Claude Code Review
N/A