Fix tomli compatibility issue for older Python version#286
Merged
Darktex merged 1 commit intoJan 12, 2026
Merged
Conversation
Darktex
reviewed
Jan 12, 2026
Darktex
left a comment
Collaborator
There was a problem hiding this comment.
Summary
This PR fixes a ModuleNotFoundError when running OpenEnv CLI commands on Python 3.10 and older by adding a fallback import for the tomli package.
Overall Assessment: Simple, correct fix. Ready to merge.
Analysis
The fix is correct. tomllib was added to Python's standard library in Python 3.11, but the project's pyproject.toml specifies requires-python = ">=3.10". The tomli package is already listed as a dependency (tomli>=2.3.0), so this import fallback works correctly.
| Aspect | Assessment |
|---|---|
| Pattern used | Standard Python compatibility pattern |
| Dependency already exists | Yes (tomli>=2.3.0 in pyproject.toml) |
| API compatibility | Yes (tomli has identical API to tomllib) |
Note
PR #285 also includes this same fix (duplicated). Consider merging this PR first or letting it be included in PR #285.
Reviewed by Claude
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addressing this issue: issue284
Summary
Fixes a
ModuleNotFoundErrorwhen running OpenEnv CLI commands on Python 3.10 and older by adding a fallback import for thetomlipackage.Problem
The
tomllibmodule is only available in Python 3.11+. When running on Python 3.10 and older, the following error occurs:Solution
Add a try/except import that falls back to
tomli(the third-party backport) whentomllibis not available:Changes
src/openenv/cli/_validation.py: Updated import to support Python 3.10 and older