[ENHANCEMENT] Restructure package for simplified installation#225
Conversation
rycerzes
left a comment
There was a problem hiding this comment.
LGTM! Having a deprecation warning of sorts would be beneficial
Also I think the dependency grouping in the updated pyproject.toml needs clarification.
Right now, core contains all the server dependencies (FastAPI, Pydantic, Uvicorn, Requests), but it’s declared under optional-dependencies. That makes it seem like core is required for normal usage, yet it's not installed by default.
|
thanks @burtenshaw for the change. Will review this. do you mind mentioning the detailed project structure before vs after this change in the PR description? It ll make the review a bit easier. Thanks! |
There was a problem hiding this comment.
@burtenshaw - whats your take on the each env's version? We don't want the repo to be a host of multiple versions of envs, given this repo is purpose-built to be framework.
There was a problem hiding this comment.
Agreed. We should just host the latest version of a limited set of envs.
@pankit-eng That's added to the description. Let me know what you think. |
I would skip this for this early version of the lib.
Understood. My thinking here was to expose an optional 'minimal' install for envs that just use |
|
@burtenshaw |
@rycerzes Ok. They already included within That said, I am not wedded to seperation I just thought it was convenient for docker builds to skips the extra |
|
Ah got it, makes sense now. The naming just threw me off - |
Understood. I'll review the docs to make sure it's clear. |
|
Thanks for the review @pankit-eng, I'll merge to release and ping relevant PRs. |
This PR solves this issue. In short, that the package is not straightforward or conventional to install or import.
DX changes
The PR has a significant amount of new lines, made mostly out of grepping and moving. The fundamental change is this:
User will install like this:
User can use the core library in their envs like so:
And install in the env tomls with
openenv[core],openenv, orgit+https://github.com/meta-pytorch/OpenEnv.git, without a subdirectory reference.Implementation
The Changes to implement this are:
openenv_coreis now a shim.openenv.coreChanges
Before
After