[FIX] make cli push compatible with hf spaces#185
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
Collaborator
Author
|
@zkwentz Can you take a look at the imports in the template. I switch them to relative imports because I wasn't sure what was planned here. |
pankit-eng
reviewed
Nov 12, 2025
| # Add ENV line before CMD | ||
| if enable_interface: | ||
| new_lines.append("ENV ENABLE_WEB_INTERFACE=true") | ||
| if ( |
Contributor
There was a problem hiding this comment.
I know this code existed earlier but is there is no cleaner way than mutating the docker files? One option was to use build args on HF to build these with the ENABLE_WEB_INTERFACE . WDYT @Vaibhavs10 ?
pankit-eng
approved these changes
Nov 12, 2025
pankit-eng
left a comment
pankit-eng
left a comment
Contributor
There was a problem hiding this comment.
Left a minor comment to learn whether there is a cleaner way
rycerzes
pushed a commit
to rycerzes/OpenEnv
that referenced
this pull request
Nov 19, 2025
…plate-for-spaces [FIX] make cli push compatible with hf spaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst testing #160, I found that there were some changes to the template which mean it was no longer compatible with hf spaces.
I updated them here: