Repository navigation
fix(examples): re-prompt session menu on invalid choice in nav demo - #69
Merged
Zhiyue-Wang merged 1 commit intoOct 12, 2026
Merged
Conversation
CLI session selection silently created a new empty session when the user entered an unexpected key. Wrap the menu in a loop so invalid choices re-prompt instead of spawning a conversation.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage ? 58.90%
=======================================
Files ? 109
Lines ? 9581
Branches ? 1496
=======================================
Hits ? 5644
Misses ? 3528
Partials ? 409 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The navigation demo's CLI session selection silently created a brand new empty session whenever the user entered an unexpected key. A stray keystroke should never spawn an empty conversation, so the menu is now wrapped in a loop that re-prompts on invalid input instead. The misleading "[2]" header on the resume section was also dropped in favor of a plain text label, and the dead start_index variable was removed along the way.
The behavior of the valid choices is unchanged: "1" starts a new session and a numeric choice resumes the matching existing session. Only invalid input now behaves differently — it shows an error message and redraws the menu. The fix mirrors what the finance_adk demo already does in its session manager.
Verified locally with a syntax check; the TUI path needs no change since its modal session picker already rejects invalid selections without creating anything.