Zlib::BufError in case of empty body response with Content-Encoding and auto_inflate use

[LukaszMaslej]

Hi,

I found edge case where making http request to one of the remote servers can raise Zlib::BufError.The case is about blank body returned by a server for 204 No Content together with header Content-Encoding: gzip .

Can be reproduced this way:

require 'socket'
server = TCPServer.new 8000
loop do

client = server.accept
client.puts <<-EOT
HTTP/1.1 204 No Content
Content-Encoding: gzip
Content-Type: application/json;charset=utf-8

EOT
client.close
end

Call like:

HTTP.use(:auto_inflate, logging: { logger: Logger.new(STDOUT) }).get('http://0.0.0.0:8000')

raise an error ... /gems/http-5.0.0.pre3/lib/http/response/inflater.rb:19:in 'finish': buffer error (Zlib::BufError).

[woutdegeyter]

@tarcieri thank you for merging the fix for this issue!
Could you tell me when we could expect a new httprb release (a new tag) so we could use this fix in our production environment?

[tarcieri]

Can talk with @ixti about it. I merged your PR but several tests recently started failing, in what appears to be something X.509 related. It would probably be best to get the test suite passing again before cutting another release.