refactor(util): merge built-in is/as type overloads#956
refactor(util): merge built-in is/as type overloads#956hsutter merged 2 commits intohsutter:mainfrom
is/as type overloads#956Conversation
|
@filipsajdak @JohelEGP Will this conflict with #701? My impression is #701 is almost ready to review again? |
Yes, that's intentional. |
|
Thanks! This is looking good. The only thing I notice is that it passes CI on everything except Xcode 13. Looks like the only problem is that Xcode 13 doesn't have C++20 I've pushed a commit to this PR to try to eliminate that dependency by adding this: ... and using that instead of Does that seem like the right solution? Hopefully that will unbreak Xcode 13... Now that we have CI (thanks again!) I can push and find out... |
|
Yup, that unbroke Xcode 13... should be ready to merge. Thanks! |
* refactor(util): merge built-in `is`/`as` type overloads * Remove dependency on C++20 feature Xcode 13 doesn't have --------- Co-authored-by: Herb Sutter <herb.sutter@gmail.com>
No description provided.