Add is and as support for std::expected#954
Closed
bluetarpmedia wants to merge 0 commit intohsutter:mainfrom
Closed
Add is and as support for std::expected#954bluetarpmedia wants to merge 0 commit intohsutter:mainfrom
is and as support for std::expected#954bluetarpmedia wants to merge 0 commit intohsutter:mainfrom
Conversation
Owner
|
Thanks! @filipsajdak @bluetarpmedia Does this conflict with #701, which I think is close to ready to review again? |
Contributor
|
There is a conflict. I can prepare an update to it. But first I will split #701. |
Contributor
Author
Thanks @filipsajdak -- I didn't mean to intrude on your work! |
Contributor
|
No intrusion. I like that you bring up the |
0a1f839 to
eb5c65b
Compare
Contributor
Author
|
I wasn't able to successfully rebase this onto the updated code in |
Contributor
|
You can always take the local branch that you updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cpp2util.hto supportisandasforstd::expectedpure2-expected-is-asregression test