Closed
Conversation
Relevant lines pasted from the grammar:
```c
//G is-as-expression:
//G prefix-expression
//G is-as-expression is-value-constraint
//GTODO type-id is-type-constraint
```
A *prefix-expression* can be an *unqualified-id*, which can also be a
*type-id*. So when the latter is implemented, it would break any code
using `identifier is` to test an expression.
I understand the usual way of disambiguating is to require parens, so I
have done that here to fix 5 `regression_tests`.
Contributor
|
I have implemented |
ntrel
changed the title
identifier is as *type-id* isidentifier is for *type-id* is
Contributor
Author
|
@filipsajdak Thanks! I've started working on type |
Contributor
|
I have implemented solution for types on cpp2 side. I am struggling with type as a template. If you will need any explanation just let me know. |
Closed
Contributor
Author
|
Closing in favour of #782. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant lines from the grammar:
Both prefix-expression and type-id can be an unqualified-id.
T isis not implemented yet, but when it is, it wouldconflict withbe parsed asidentifier isto test an expression.I understand the usual way of disambiguating between a type or an expression is to require parens to force an expression, so I have done that here to fix 5
regression_tests. I have added a temporary error foridentifier is, because that should be the unimplementedT isform.Update: So I've moved the type-id form above prefix-expression in the grammar.