[cpp2util] as: add constexpr branch for optionals#1062
Closed
sookach wants to merge 1 commit intohsutter:mainfrom
Closed
[cpp2util] as: add constexpr branch for optionals#1062sookach wants to merge 1 commit intohsutter:mainfrom
sookach wants to merge 1 commit intohsutter:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aims to resolve #1061. This issue is very similar to #1057, where the as for optionals is defined after the general function. @hsutter @filipsajdak Would definitely like to hear some feedback/suggestions for how to handle this bug. My solution was to add a 'type trait' for checking if a type is an optional, but I'm not sure if this fits into cpp2's design philosophy. @bluetarpmedia I tested this on macos with clang18, let me know if this fix works for you. Thanks everyone!