Repository navigation
fix(macOS): preserve PTYs, finish shutdown and fit usage reports - #171
Merged
Merged
Conversation
added 4 commits
October 31, 2026 12:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, closing the main window destroyed xterm while its PTYs remained alive; a companion-service rejection could also abort the quit sequence before terminal shutdown and the final save. Keep the window hidden on close, restore it on Dock activation, and continue independent cleanup after service failures while still awaiting PTY exits.
At the minimum 920×620 window with 125% UI scale, the usage report clipped its Sources tab and paging controls. Constrain the Mac report grid to its available height and compact the header at short heights.
Large Mac history snapshots now use asynchronous gzip level 1 in an atomic v3 JSON envelope. Events and collector cursors remain in one transaction with the existing collection frequency, retention and fsync/rename protocol. A local 27.1 MB snapshot became 6.1 MB (77.35% fewer serialized bytes); this is not a claim about total CPU speed or physical SSD writes. Small snapshots remain v2. Both versions load on Mac; the included exporter restores exact v2 bytes for downgrade. Older builds preserve v3 untouched but cannot read it. Linux/Windows retain their v2 writer and previous shutdown failure behavior.
Includes the existing deterministic browser/prompt-deadline smoke fixes and tab-aware packaged usage checks.
Validation at
038d73c:The installed app and active terminal processes were preserved. Long-duration human acceptance, physical keyboard behavior and native Intel Mac acceptance remain unverified. The local candidate retains version 1.8.5-beta2.