Remove annotations support - #46
Merged
Merged
Conversation
janlam7
commented
Sep 9, 2026
janlam7
commented
Contributor
- Removes the doctrine/annotations dependency
- Since this will be released as a BC break, the code has been rigorously cleaned up.
Remove the unused Events::entityChanged BC alias, add native object/ ?object parameter and return types throughout EntityChangedEvent, EntityChangedListener and the metadata providers instead of leaning on mixed plus docblocks, and fix a docblock on EntityMutationMetadataProvider::hasAssociationChanged that documented its association-value parameters as string instead of object. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Doctrine\ORM\Proxy\Proxy, Doctrine\ORM\Tools\Setup and EntityManager::create() are all deprecated in the installed doctrine/orm version. Switch to Doctrine\Persistence\Proxy (already used elsewhere in this codebase), ORMSetup::createAttributeMetadataConfiguration(), and DriverManager::getConnection() plus the EntityManager constructor. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
actions/checkout@v2 runs on the Node16 runtime GitHub is deprecating, same class of issue already fixed for actions/cache in a prior commit. src/Event/EntityChangedEvent.php extends Doctrine\Common\EventArgs and tests use Doctrine\Common\EventManager, both of which live in the doctrine/event-manager package; it was only ever installed as a transitive dependency of doctrine/orm, so declare it directly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
phonixor
approved these changes
Sep 10, 2026
FlorisTurkenburg
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.