Skip to content
This repository was archived by the owner on Sep 20, 2021. It is now read-only.

Adding Support for Indices#61

Open
carlbateson wants to merge 1 commit intohoaproject:masterfrom
carlbateson:rubicon9/indices
Open

Adding Support for Indices#61
carlbateson wants to merge 1 commit intohoaproject:masterfrom
carlbateson:rubicon9/indices

Conversation

@carlbateson
Copy link
Copy Markdown

  • Adding token ^
  • Updating order of operation to include indices
  • Adding action for new #indices (using php pow function)
  • NB, tests delayed since it appears the suite is already failing?

- Adding token ^
- Updating order of operation to include indices
- Adding action for new #indices (using php pow function)
- NB, tests delayed since it appears the suite is already failing?
Copy link
Copy Markdown
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR! Really appreciated. This relates to #25 and #26. You must read the latter PR (cc @osaris) where we have a discussion about testing and the ^ operator.

%token minus \-|−
%token times \*|×
%token div /|÷
%token indices \^
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using the token name pow?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using either indices or exponent would be more correct but it's a trivial thing, I don't mind either way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

2 participants