merge rrweb PR #909#78
Merged
Merged
Conversation
set empty link elements to loaded by default Clean up stylesheet manager Remove attribute mutation code Update packages/rrweb/test/record.test.ts Update packages/rrweb/test/record.test.ts Update packages/rrweb/test/record.test.ts Bump minimist from 1.2.5 to 1.2.6 (#902) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Speed up snapshotting of many new dom nodes (#903) * Speed up snapshotting of many new dom nodes By avoiding reflow we shave about 15-25% off our snapshotting time * Improve newlyAddedElement docs * Optimize needMaskingText by using el.closest and less recursion * Serve all rrweb dist files * Split serializeNode into smaller functions Makes it easier to profile * Slow down cpu enhance tracing on fast machines * Increase timeout * Perf: only loop through ancestors when they have something to compare to * Perf: `hasNode` is cheaper than `getMeta` * Perf: If parents where already checked, no need to do it again * Perf: reverse for loops are faster Because they only do the .lenght check once. In this case I don't think we'll see much performance gains if any * Clean up code * Perf: check ancestors once with isBlocked * guessing this might fixes canvas test * Update packages/rrweb/src/record/observers/canvas/webgl.ts Co-authored-by: yz-yu <yanzhen@smartx.com> * Fix #904 (#906) Properly remove crossorigin attribute * Bump minimist from 1.2.5 to 1.2.6 (#902) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: yz-yu <yanzhen@smartx.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Move require out of time sensitive assert Update packages/rrweb/scripts/repl.js Update packages/rrweb/test/record.test.ts Update packages/rrweb/src/record/index.ts Add todo Add waitForRAF, its more reliable than waitForTimeout Remove flaky tests Add recording stylesheets in iframes Remove variability from flaky test Make test more robust Fix naming Update dive-into-event.md (#914) move browser-only rrdom features to the new rrdom package (#913) integrate turborepo in monorepo (#918) * integrate turborepo in monorepo * integrate turborepo in monorepo unify typescript version and rollup plugins (#921) Add test cases for inlineImages Add test cases for inlineImages Record iframe mutations cross page Test: should record images inside iframe with blob url after iframe was reloaded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rrweb-io/rrweb#909 with follow-up fix rrweb-io/rrweb#926
set empty link elements to loaded by default
Clean up stylesheet manager
Remove attribute mutation code
Update packages/rrweb/test/record.test.ts
Update packages/rrweb/test/record.test.ts
Update packages/rrweb/test/record.test.ts
Bump minimist from 1.2.5 to 1.2.6 (#902)
Bumps minimist from 1.2.5 to 1.2.6.
updated-dependencies:
dependency-type: indirect
...
Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Speed up snapshotting of many new dom nodes (#903)
By avoiding reflow we shave about 15-25% off our snapshotting time
Improve newlyAddedElement docs
Optimize needMaskingText by using el.closest and less recursion
Serve all rrweb dist files
Split serializeNode into smaller functions
Makes it easier to profile
Slow down cpu enhance tracing on fast machines
Increase timeout
Perf: only loop through ancestors when they have something to compare to
Perf:
hasNodeis cheaper thangetMetaPerf: If parents where already checked, no need to do it again
Perf: reverse for loops are faster
Because they only do the .lenght check once. In this case I don't think we'll see much performance gains if any
Clean up code
Perf: check ancestors once with isBlocked
guessing this might fixes canvas test
Update packages/rrweb/src/record/observers/canvas/webgl.ts
Co-authored-by: yz-yu yanzhen@smartx.com
Properly remove crossorigin attribute
Bumps minimist from 1.2.5 to 1.2.6.
updated-dependencies:
dependency-type: indirect
...
Signed-off-by: dependabot[bot] support@github.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: yz-yu yanzhen@smartx.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Move require out of time sensitive assert
Update packages/rrweb/scripts/repl.js
Update packages/rrweb/test/record.test.ts
Update packages/rrweb/src/record/index.ts
Add todo
Add waitForRAF, its more reliable than waitForTimeout
Remove flaky tests
Add recording stylesheets in iframes
Remove variability from flaky test
Make test more robust
Fix naming
Update dive-into-event.md (#914)
move browser-only rrdom features to the new rrdom package (#913)
integrate turborepo in monorepo (#918)
integrate turborepo in monorepo
integrate turborepo in monorepo
unify typescript version and rollup plugins (#921)
Add test cases for inlineImages
Add test cases for inlineImages
Record iframe mutations cross page
Test: should record images inside iframe with blob url after iframe was reloaded