Skip to content

merge rrweb PR #909#78

Merged
Vadman97 merged 2 commits into
masterfrom
vadim/merge-909
Jun 30, 2022
Merged

merge rrweb PR #909#78
Vadman97 merged 2 commits into
masterfrom
vadim/merge-909

Conversation

@Vadman97

Copy link
Copy Markdown
Member

rrweb-io/rrweb#909 with follow-up fix rrweb-io/rrweb#926

set empty link elements to loaded by default

Clean up stylesheet manager

Remove attribute mutation code

Update packages/rrweb/test/record.test.ts

Update packages/rrweb/test/record.test.ts

Update packages/rrweb/test/record.test.ts

Bump minimist from 1.2.5 to 1.2.6 (#902)

Bumps minimist from 1.2.5 to 1.2.6.


updated-dependencies:

  • dependency-name: minimist
    dependency-type: indirect
    ...

Signed-off-by: dependabot[bot] support@github.com

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Speed up snapshotting of many new dom nodes (#903)

  • Speed up snapshotting of many new dom nodes

By avoiding reflow we shave about 15-25% off our snapshotting time

  • Improve newlyAddedElement docs

  • Optimize needMaskingText by using el.closest and less recursion

  • Serve all rrweb dist files

  • Split serializeNode into smaller functions

Makes it easier to profile

  • Slow down cpu enhance tracing on fast machines

  • Increase timeout

  • Perf: only loop through ancestors when they have something to compare to

  • Perf: hasNode is cheaper than getMeta

  • Perf: If parents where already checked, no need to do it again

  • Perf: reverse for loops are faster

Because they only do the .lenght check once. In this case I don't think we'll see much performance gains if any

  • Clean up code

  • Perf: check ancestors once with isBlocked

  • guessing this might fixes canvas test

  • Update packages/rrweb/src/record/observers/canvas/webgl.ts

Co-authored-by: yz-yu yanzhen@smartx.com

  • Fix #904 (#906)

Properly remove crossorigin attribute

  • Bump minimist from 1.2.5 to 1.2.6 (#902)

Bumps minimist from 1.2.5 to 1.2.6.


updated-dependencies:

  • dependency-name: minimist
    dependency-type: indirect
    ...

Signed-off-by: dependabot[bot] support@github.com

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: yz-yu yanzhen@smartx.com
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Move require out of time sensitive assert

Update packages/rrweb/scripts/repl.js

Update packages/rrweb/test/record.test.ts

Update packages/rrweb/src/record/index.ts

Add todo

Add waitForRAF, its more reliable than waitForTimeout

Remove flaky tests

Add recording stylesheets in iframes

Remove variability from flaky test

Make test more robust

Fix naming

Update dive-into-event.md (#914)

move browser-only rrdom features to the new rrdom package (#913)

integrate turborepo in monorepo (#918)

  • integrate turborepo in monorepo

  • integrate turborepo in monorepo

unify typescript version and rollup plugins (#921)

Add test cases for inlineImages

Add test cases for inlineImages

Record iframe mutations cross page

Test: should record images inside iframe with blob url after iframe was reloaded

Juice10 and others added 2 commits June 30, 2022 14:22
set empty link elements to loaded by default

Clean up stylesheet manager

Remove attribute mutation code

Update packages/rrweb/test/record.test.ts

Update packages/rrweb/test/record.test.ts

Update packages/rrweb/test/record.test.ts

Bump minimist from 1.2.5 to 1.2.6 (#902)

Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Speed up snapshotting of many new dom nodes (#903)

* Speed up snapshotting of many new dom nodes

By avoiding reflow we shave about 15-25% off our snapshotting time

* Improve newlyAddedElement docs

* Optimize needMaskingText by using el.closest and less recursion

* Serve all rrweb dist files

* Split serializeNode into smaller functions

Makes it easier to profile

* Slow down cpu enhance tracing on fast machines

* Increase timeout

* Perf: only loop through ancestors when they have something to compare to

* Perf: `hasNode` is cheaper than `getMeta`

* Perf: If parents where already checked, no need to do it again

* Perf: reverse for loops are faster

Because they only do the .lenght check once. In this case I don't think we'll see much performance gains if any

* Clean up code

* Perf: check ancestors once with isBlocked

* guessing this might fixes canvas test

* Update packages/rrweb/src/record/observers/canvas/webgl.ts

Co-authored-by: yz-yu <yanzhen@smartx.com>

* Fix #904 (#906)

Properly remove crossorigin attribute

* Bump minimist from 1.2.5 to 1.2.6 (#902)

Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: yz-yu <yanzhen@smartx.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Move require out of time sensitive assert

Update packages/rrweb/scripts/repl.js

Update packages/rrweb/test/record.test.ts

Update packages/rrweb/src/record/index.ts

Add todo

Add waitForRAF, its more reliable than waitForTimeout

Remove flaky tests

Add recording stylesheets in iframes

Remove variability from flaky test

Make test more robust

Fix naming

Update dive-into-event.md (#914)

move browser-only rrdom features to the new rrdom package (#913)

integrate turborepo in monorepo (#918)

* integrate turborepo in monorepo

* integrate turborepo in monorepo

unify typescript version and rollup plugins (#921)

Add test cases for inlineImages

Add test cases for inlineImages

Record iframe mutations cross page

Test: should record images inside iframe with blob url after iframe was reloaded
@Vadman97 Vadman97 merged commit 1cae2ed into master Jun 30, 2022
@Vadman97 Vadman97 deleted the vadim/merge-909 branch June 30, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants