Anthony/hig 156 change the color style of the cursor to#25
Merged
eightants merged 16 commits intoFeb 21, 2021
Merged
Conversation
…anthony/hig-122-add-feature-to-modify-threshold-for
…anthony/hig-122-add-feature-to-modify-threshold-for
Co-authored-by: Jay Khatri <j@jaykhatri.com>
eightants
requested review from
jay-khatri
and removed request for
jay-khatri
jay-khatri
approved these changes
Feb 21, 2021
jay-khatri
left a comment
jay-khatri
left a comment
Contributor
There was a problem hiding this comment.
lgtm, pending that one comment, and tests w/ client and frontend. Also, the build seems to be failing; I think updating node will fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, I can't see the cursor change being reflected in the frontend, although the original cursor has been remove and replaced
This PR adds parameters in the Replayer config to allow customizing the speed of skipping Inactive periods. It also changes the style of the cursor in the replayer to have a white background to work better with colors.
To support these changes, we changed the build process to use webpack instead of rollup.